[foxy backport] Backport unit tests for coverage into foxy #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ahcorde
approved these changes
Oct 9, 2020
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part8
branch
from
c7cde75 to
a3dd124
Compare
* Improved test_subscription_options Signed-off-by: ahcorde <ahcorde@gmail.com> * used RCLCPP_EXPECT_THROW_EQ in test_subcription_options Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com>
* Covered resolve_use_intra_process Signed-off-by: ahcorde <ahcorde@gmail.com> * used RCLCPP_EXPECT_THROW_EQ in test_subscription_throws_intraprocess Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Make sure to #include what is used, and also fix a typo in a test. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This gets us to 96% line coverage. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add missing tests API * Reformat style error throw * Add internal errors tests Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Change value used as max representation * Add coverage tests time * Add call to detach clock * Add tests time * Add duration construction tests * Add const qualifier to constants * Add check clock stays the same * Make operator RCLCPP_PUBLIC * Add tests exceptions duration * Fix division by 0 on windows Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Add test for ParameterService Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address PR feedback Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part9
branch
from
31f2614 to
741c6af
Compare
brawner
changed the base branch from
brawner/rclcpp-backport-tests-part8
to
brawner/rclcpp-backport-tests-part1
delete-merged-branch
bot
deleted the
brawner/rclcpp-backport-tests-part9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests and minor code fixes for backporting into foxy. This will be rebased and merged into #1383 before ultimate rebase and merging onto foxy.
Coverage PRs: #1358, #1359, #1360, #1361, #1363, #1347, #1355