[foxy backport] Backport tests for increased coverage #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part10
branch
from
6ea7c02 to
1eae2fc
Compare
|
Squashed a small change into
|
ahcorde
approved these changes
Oct 9, 2020
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part10
branch
from
1eae2fc to
f30e2c5
Compare
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part9
branch
from
31f2614 to
741c6af
Compare
Signed-off-by: Stephen Brawner <brawner@gmail.com>
In particular, add API coverage for spin_node_until_future_complete, spin_until_future_complete, and spin_node_once. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add unit tests for qos and qos_event files Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address PR Feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix windows CI Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase coverage of WaitSetTemplate Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR fixup Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part10
branch
from
f30e2c5 to
319e991
Compare
brawner
changed the base branch from
brawner/rclcpp-backport-tests-part9
to
brawner/rclcpp-backport-tests-part1
|
I think adding the #1317 to this mix fixes the above test failure
|
delete-merged-branch
bot
deleted the
brawner/rclcpp-backport-tests-part10
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last (hopefully) of PRs to backport commits for increased coverage into foxy. This will be rebase and merged onto #1383 before ultimate being rebase and merged onto foxy.
Bug fix PRs: #1317
Coverage PRs: #1364, #1365, #1352, #1366, #1369, #1368, #1296