Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galactic: for_each_callback_group backport #1741

Merged
merged 12 commits into from
Aug 19, 2021
Merged

Galactic: for_each_callback_group backport #1741

merged 12 commits into from
Aug 19, 2021

Commits on Aug 4, 2021

  1. Added for_each_callback non-virtual method, static members to node_ba… 

    …se.hpp, updated the

for_each_callback_group wrapper method in lifecycle_node and node.cpp,
added a thread safe global map of mutexes in node_base.

Implemented the suggestions in preliminary review.

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    2fbc5ce View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Typecasting added to static_executor_entities_collector, uncrustify f… 

    …ixes

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    64d258f View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. test_node.cpp changed callback_groups test 

    Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    0acbc8b View commit details
    Browse the repository at this point in the history

  2. changed test_memory_strategy, exec entities collector to use for_each… 

    …_cb_group

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    9784a85 View commit details
    Browse the repository at this point in the history

  3. modified tests: lifecycle_node, allocator_memory_strategy to use for_… 

    …each_cb_group

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    e6733bf View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. cleanup, added nullptr check to node.cpp, lifecyclenode.cpp 

    Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    d77e812 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. changed map_ptr to map object, removed lazy init for map 

    Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    87df4a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. added free function global_for_each_callback_group, removed dynamic p… 

    …ointer cast

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    9eb1cf7 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. deleted default contructor/destuctor, added private members to map_of… 

    …_mutexes

Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    39245ee View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. cleanup, removed mutex NULL check, added underscore to private members 

    Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    f94f139 View commit details
    Browse the repository at this point in the history

  2. removed blank line and static member access using this 

    Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    e654970 View commit details
    Browse the repository at this point in the history

  3. added RCLCPP_PUBLIC to global_for_each_callback_group for windows CI 

    Signed-off-by: Aditya Pande <aditya050995@gmail.com>
    @adityapande-1995
    adityapande-1995 committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    85590ed View commit details
    Browse the repository at this point in the history