Support intra-process communication between Clients and Services #1847

mauropasse · 2021-12-16T21:37:45Z

These changes extend the intra-process capabilities to support intra-process client/services communication, so no need to go through the DDS when sending client requests / services responses, when they belong to the same process.

Missing: Add unit tests.
Design: https://github.com/mauropasse/design/blob/mauro/gh-pages-ipc-clients-services/articles/intraprocess_communication.md

@clalancette
@alsora

alsora · 2022-03-18T14:16:03Z

CI

Linux
Linux-aarch64
Windows

alsora · 2022-03-21T11:13:51Z

CI

Linux
Linux-aarch64
Windows

alsora · 2022-03-21T17:26:25Z

CI

Linux
Linux-aarch64
Windows

alsora · 2022-03-21T20:02:41Z

New CI with updated cyclonedds

Linux
Linux-aarch64
Windows

alsora · 2022-03-22T12:23:04Z

rclcpp/include/rclcpp/client.hpp

+  /// Implementation detail.
+  RCLCPP_PUBLIC
+  void
+  setup_intra_process(


this should probably be protected (and also the using definition above)

Done in 0d17a8e

alsora · 2022-03-22T12:25:41Z

rclcpp/include/rclcpp/client.hpp

@@ -676,7 +711,7 @@ class Client : public ClientBase
    PromiseWithRequest promise;
    auto shared_future = promise.get_future().share();
    auto req_id = async_send_request_impl(
-      *request,
+      request,


why not std::move as in the other calls above?

Not moving here because needs to be valid for later use in line 718

alsora · 2022-03-22T12:29:51Z

CI

Linux
Linux-aarch64
Windows

alsora · 2022-03-22T12:34:10Z

rclcpp/include/rclcpp/client.hpp

+
+private:
+  using ClientIntraProcessT = rclcpp::experimental::ClientIntraProcess<ServiceT>;
+  std::shared_ptr<ClientIntraProcessT> client_intra_process_;


to match subscriptions implementation, we should have that client_intra_process_ is a protected member in client_base.hpp.
Its type will be ClientIntraProcessBase and the using definition can be moved to the create_intra_process_client

The same applies to servers.

Done in bec9017

alsora · 2022-03-22T12:37:04Z

rclcpp/include/rclcpp/detail/resolve_use_intra_process.hpp

 bool
-resolve_use_intra_process(const OptionsT & options, const NodeBaseT & node_base)
+resolve_use_intra_process(const IntraProcessSetting & ipc_setting, const NodeBaseT & node_base)


IntraProcessSetting is an enum, we can avoid passing that as a reference as it's likely to be a pessimization (and may cause confusion between the enum value and the memory address)

Done in d19d5c2

alsora · 2022-03-22T12:39:51Z

rclcpp/include/rclcpp/experimental/buffers/intra_process_buffer.hpp

+  // Not to be used in this class. Todo: review base class to avoid this.
+  bool use_take_shared_method() const override
+  {
+    throw std::runtime_error(


do we really need to throw here?

I'm just returning false now: 08290a8

alsora · 2022-03-22T12:43:24Z

rclcpp/include/rclcpp/experimental/client_intra_process.hpp

+    auto & typed_response = data_ptr->first;
+    auto & value = data_ptr->second;
+
+    if (std::holds_alternative<Promise>(value)) {


it would be nice if we could avoid duplicating this logic between here and client.hpp

rclcpp/src/rclcpp/intra_process_manager.cpp

rclcpp/src/rclcpp/parameter_service.cpp

ros-discourse · 2022-04-26T21:44:23Z

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-04-21/25293/1

alsora · 2022-06-01T10:27:20Z

Hi, can we get a review here?

alsora · 2022-08-15T09:39:54Z

Hi, anyone available for a review?

alsora · 2022-08-30T11:21:32Z

Friendly ping for a review

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

alsora · 2023-02-10T11:31:17Z

@wjwwood @clalancette @audrow @hidmic @ivanpauno can we get a review?
this PR has been open for more than 1 year

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

mauropasse mentioned this pull request Dec 17, 2021

Status of today's ROS 2 message delivery mechanisms #1750

Open

mauropasse marked this pull request as draft December 17, 2021 14:50

mauropasse force-pushed the mauro/ipc-cli-serv-qos-getters branch 3 times, most recently from 17a8555 to 78ea732 Compare March 18, 2022 13:51

alsora reviewed Mar 22, 2022

View reviewed changes

rclcpp/src/rclcpp/intra_process_manager.cpp Outdated Show resolved Hide resolved

alsora reviewed Mar 22, 2022

View reviewed changes

rclcpp/src/rclcpp/parameter_service.cpp Outdated Show resolved Hide resolved

mauropasse marked this pull request as ready for review March 23, 2022 16:19

clalancette assigned wjwwood and clalancette Apr 22, 2022

mauropasse force-pushed the mauro/ipc-cli-serv-qos-getters branch from bec9017 to b6245f2 Compare May 26, 2022 09:55

clalancette requested a review from wjwwood June 1, 2022 13:31

audrow changed the base branch from master to rolling June 28, 2022 14:21

mauropasse force-pushed the mauro/ipc-cli-serv-qos-getters branch 2 times, most recently from 98aad33 to abf4e71 Compare September 23, 2022 12:15

Mauro Passerino added 2 commits September 23, 2022 13:18

Support intra-process communication: Clients & Services

b2d743a

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

Add on new request/responses callbacks to IPC srv/cli

0a98fda

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

mauropasse force-pushed the mauro/ipc-cli-serv-qos-getters branch from abf4e71 to 0a98fda Compare September 23, 2022 12:18

Clear intra-process manager from destroyed cli/srv

b995963

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

mauropasse force-pushed the mauro/ipc-cli-serv-qos-getters branch from d45b7ea to b995963 Compare October 3, 2022 13:57

Missing create_intra_process_service in constructor

fb2c117

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

alsora mentioned this pull request Nov 1, 2022

SharedFuture from async_send_request never becomes valid #2039

Closed

alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023

Support intra-process communication: Clients & Services (ros2#1847)

10e66d6

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

mauropasse pushed a commit to mauropasse/rclcpp that referenced this pull request Nov 8, 2023

Support intra-process communication: Clients & Services (ros2#1847)

8f5f88a

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

mauropasse pushed a commit to mauropasse/rclcpp that referenced this pull request Nov 8, 2023

Support intra-process communication: Clients & Services (ros2#1847)

79697cb

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

mauropasse mentioned this pull request Dec 22, 2023

ROS 2 services are not 1 to 1 communication: responses are copied and sent to all clients #2397

Open

alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Jan 30, 2024

Support intra-process communication: Clients & Services (ros2#1847)

2f48887

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

apojomovsky pushed a commit to apojomovsky/rclcpp that referenced this pull request Jun 20, 2024

Support intra-process communication: Clients & Services (ros2#1847)

0b966cd

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

apojomovsky pushed a commit to apojomovsky/rclcpp that referenced this pull request Jun 21, 2024

Support intra-process communication: Clients & Services (ros2#1847)

58d2a04

Signed-off-by: Mauro Passerino <mpasserino@irobot.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support intra-process communication between Clients and Services #1847

Support intra-process communication between Clients and Services #1847

mauropasse commented Dec 16, 2021 •

edited

Loading

alsora commented Mar 18, 2022

alsora commented Mar 21, 2022

alsora commented Mar 21, 2022

alsora commented Mar 21, 2022

alsora Mar 22, 2022 •

edited

Loading

mauropasse Mar 23, 2022

alsora Mar 22, 2022

mauropasse Mar 23, 2022

alsora commented Mar 22, 2022

alsora Mar 22, 2022 •

edited

Loading

mauropasse Mar 23, 2022

alsora Mar 22, 2022 •

edited

Loading

mauropasse Mar 23, 2022

alsora Mar 22, 2022

mauropasse Mar 23, 2022

alsora Mar 22, 2022

ros-discourse commented Apr 26, 2022

alsora commented Jun 1, 2022

alsora commented Aug 15, 2022

alsora commented Aug 30, 2022

alsora commented Feb 10, 2023

Support intra-process communication between Clients and Services #1847

Are you sure you want to change the base?

Support intra-process communication between Clients and Services #1847

Conversation

mauropasse commented Dec 16, 2021 • edited Loading

alsora commented Mar 18, 2022

alsora commented Mar 21, 2022

alsora commented Mar 21, 2022

alsora commented Mar 21, 2022

alsora Mar 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alsora commented Mar 22, 2022

alsora Mar 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alsora Mar 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ros-discourse commented Apr 26, 2022

alsora commented Jun 1, 2022

alsora commented Aug 15, 2022

alsora commented Aug 30, 2022

alsora commented Feb 10, 2023

mauropasse commented Dec 16, 2021 •

edited

Loading

alsora Mar 22, 2022 •

edited

Loading

alsora Mar 22, 2022 •

edited

Loading

alsora Mar 22, 2022 •

edited

Loading