small improvements to node_main.cpp.in

[alsora]

Small improvements identified by clang tidy for the node_main.cpp.in file.

warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
1:   for (auto clazz : classes) {

and

warning: implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
1:     if (!(name.compare(class_name))) {

Signed-off-by: Alberto Soragna alberto.soragna@gmail.com

[fujitatomoya]

lgtm

[nuclearsandwich]

@ros-pull-request-builder retest this please

See: ros2/ci#621

[clalancette]

Looks good to me with green CI.

[alsora]

CI run:

• Linux
• Linux-aarch64
• Windows

[alsora]

Merging as the warnings in linux-aarch64 are unrelated and appear also in other builds.