Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement matched event #2105

Conversation

Barry-Xu-2018
Copy link
Collaborator

Address ros2/rmw#330

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Barry-Xu-2018 Barry-Xu-2018 force-pushed the topic-add-matched-unmatched-event-support branch from fa6b5f2 to f090d10 Compare March 6, 2023 04:48
@Barry-Xu-2018
Copy link
Collaborator Author

Rebase was done.

Signed-off-by: Barry Xu <barry.xu@sony.com>
@fujitatomoya
Copy link
Collaborator

@Barry-Xu-2018 friendly ping, this still needs to be rebased.

@Barry-Xu-2018 Barry-Xu-2018 force-pushed the topic-add-matched-unmatched-event-support branch from f090d10 to 50cb86c Compare March 17, 2023 02:43
@Barry-Xu-2018 Barry-Xu-2018 changed the title Add matched & unmatched event support Implement matched event Mar 17, 2023
@mjcarroll mjcarroll merged commit cb08c79 into ros2:rolling Mar 22, 2023
Barry-Xu-2018 added a commit to Barry-Xu-2018/rclcpp that referenced this pull request Jan 12, 2024
Signed-off-by: Barry Xu <barry.xu@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants