Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all rclcpp packages to C++17. #2121

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Update all rclcpp packages to C++17. #2121

merged 1 commit into from
Mar 7, 2023

Commits on Mar 7, 2023

  1. Update all rclcpp packages to C++17. 

    The main reason to do this is so that we can compile rclcpp
with the clang static analyzer.  As of clang++-14 (what is in
Ubuntu 22.04), the default still seems to be C++14, so we need
to specify C++17 so that new things in the rclcpp headers work
properly.

Further, due to reasons I don't fully understand, I needed to
set CMAKE_CXX_STANDARD_REQUIRED in order for clang to really use
that version.  So set this as well.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d4781d0 View commit details
    Browse the repository at this point in the history