Runtime Interface Reflection: Dynamic Typesupport Wrappers #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
31 tasks
methylDragon
force-pushed
the
runtime_interface_reflection_wrappers
branch
2 times, most recently
from
685868c to
78f338e
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection_wrappers
branch
from
1ba34df to
8b254c4
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection_wrappers
branch
from
8b254c4 to
d4b03f9
Compare
methylDragon
force-pushed
the
runtime_interface_reflection_wrappers
branch
from
516ee56 to
d4b03f9
Compare
|
I had hoped to make this easier to review by splitting it off, but managing the branches is becoming too troublesome (since I need to be changing some signatures.) I am closing this for now, but I might split these classes off again in a future PR. The changes here will be lumped into #2077 instead, until they are split out again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the runtime interface reflection subscription feature of REP-2011: ros2/ros2#1374
It is a dependency of: #2077
Depends on:
Description
This PR implements C++ wrapper classes for the rosidl_dynamic_typesupport dynamic type/type builder/data structs that help manage lifetime and type casting.
They also feature many templated functions to lessen the reading burden for any new users of dynamic typesupport.
rclcpp::dynamic_typesupport::DynamicDatarclcpp::dynamic_typesupport::DynamicMessagerclcpp::dynamic_typesupport::DynamicMessageTyperclcpp::dynamic_typesupport::DynamicSerializationSupportrclcpp::dynamic_typesupport::DynamicTypeBuilderrclcpp::dynamic_typesupport::DynamicTypeI also created a typesupport wrapper class that wraps the
rosidl_message_type_support_tthat should be passed into a subscription. It'll manage all the necessary lifetimes.rclcpp::dynamic_typesupport::DynamicMessageTypeSupportEverything builds nicely, though I don't have tests written yet...