Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the test_subscription.cpp tests. #2227

Merged
merged 1 commit into from
Jun 26, 2023

Commits on Jun 26, 2023

  1. Revamp the test_subscription.cpp tests.

    The original motiviation to do this was a crash during
    teardown when using a newer version of gtest.  But while
    I was in here, I did a small overall cleanup, including:
    
    1.  Moving code closer to where it is actually used.
    2.  Getting rid of unused 'using' statements.
    3.  Adding in missing includes.
    4.  Properly tearing down and recreating the rclcpp
        context during test teardown (this fixed the actual
        bug).
    5.  Making class members private where possible.
    6.  Renaming class methods to our usual conventions.
    
    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    db9f8d1 View commit details
    Browse the repository at this point in the history