Commits on Aug 18, 2023

1. Do not crash Executor when send_response fails due to client failure. (… …

   …#2276)
   
   * Do not crash Executor when send_response fails due to client failure.
   
   Related to ros2/ros2#1253
   
   It is not sane that a faulty client can crash our service Executor, as
   discussed in the referred issue, if the client is not setup properly,
   send_response may return RCL_RET_TIMEOUT, we should not throw an error
   in this case.
   
   Signed-off-by: Zang MingJie <zealot0630@gmail.com>
   
   * Update rclcpp/include/rclcpp/service.hpp
   
   Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
   Signed-off-by: Zang MingJie <zealot0630@gmail.com>
   
   * address review comments.
   
   Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
   
   ---------
   
   Signed-off-by: Zang MingJie <zealot0630@gmail.com>
   Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
   Co-authored-by: Zang MingJie <zealot0630@gmail.com>
   (cherry picked from commit fbe8f28)

   

   fujitatomoya authored and mergify[bot] committed Aug 18, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 3e10b01
   • Browse repository at this point

   Copy the full SHA

   3e10b01 View commit details

   Browse the repository at this point in the history