Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic correct typeadapter deduction (backport #2294) #2298

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 6, 2023

This is an automatic backport of pull request #2294 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fix TypeAdapter deduction

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
(cherry picked from commit 5e152d7)
@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

windows failure (timer manager) is unrelated.

@fujitatomoya fujitatomoya merged commit b82da1a into iron Sep 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/iron/pr-2294 branch September 15, 2023 00:19
nachovizzo pushed a commit to nachovizzo/rclcpp that referenced this pull request Oct 3, 2023
* fix TypeAdapter deduction

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
(cherry picked from commit 5e152d7)

Co-authored-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Ignacio Vizzo <ignacio@dexory.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants