-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use namespaces #328
Use namespaces #328
Conversation
(actual change to topic names in next commit)
for node names, namespaces, and topic/service names
rclcpp/include/rclcpp/client.hpp
Outdated
// *INDENT-ON* | ||
rcl_ret_t ret = rcl_send_request(get_client_handle(), request.get(), &sequence_number); | ||
if (RCL_RET_OK != ret) { | ||
rclcpp::exceptions::throw_from_rcl_error(ret); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this not get a prefix/suffix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: 2ebf066
{ | ||
char * expanded_topic = nullptr; | ||
rcl_allocator_t allocator = rcl_get_default_allocator(); | ||
rcutils_allocator_t rcutils_allocator = rcutils_get_default_allocator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the diff between the two allocators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing right now, but they are technically different. If we were to change the default allocator for rcl versus rcutils, then this difference would be good to have. If it were someone else's code I would not require them to do future proof their code in this way.
Since it already exists, I'll leave it as-is.
Connects to ros2/rcl#137
Examples of it in use:
"full" topic name check (post expansion check):
Services:
Node name (locally modified):
Namespace (locally modified):