Code

Read only parameters#495

Code

Merged

wjwwood merged 48 commits intomasterros2/rclcpp:masterfrom read_only_parametersros2/rclcpp:read_only_parametersCopy head branch name to clipboardApr 23, 2019

+3,064-365

Commits

Commits on Feb 22, 2019

• in progress broken test_time_source

  Show description for 73553ec
  

  sloretz

  authored and

  wjwwood

  committed
  73553ec

• style

  Show description for 88a74ff
  

  sloretz

  authored and

  wjwwood

  committed
  88a74ff

• test undeclared params

  Show description for bc8457d
  

  sloretz

  authored and

  wjwwood

  committed
  bc8457d

• Only get parameter if it is set

  Show description for a6fc8de
  

  sloretz

  authored and

  wjwwood

  committed
  a6fc8de

• doc fixup

  Show description for 7e19756
  wjwwood

  committed
  7e19756

• use override rather than virtual in places

  Show description for 2597f46
  wjwwood

  committed
  2597f46

• rename ParameterInfo_t to ParameterInfo and just use struct, no typedef

  Show description for 347449d
  wjwwood

  committed
  347449d

• add method to access ParameterValue within a Parameter

  Show description for 304ba62
  wjwwood

  committed
  304ba62

• enable get<Parameter> and get<ParameterValue> on Parameter class

  Show description for 6e5aae9
  wjwwood

  committed
  6e5aae9

• avoid const pass by value

  Show description for 38c7670
  wjwwood

  committed
  38c7670

• match type of enum in C++ to type used in message definition

  Show description for c11654e
  wjwwood

  committed
  c11654e

• fixup after rebase

  Show description for b3325aa
  wjwwood

  committed
  b3325aa

• more fixup after rebase

  Show description for 189c02e
  wjwwood

  committed
  189c02e

• replace create_parameter with declare_parameter

  Show description for 85b0377
  wjwwood

  committed
  85b0377

• provide implementation for templated declare_parameter method

  Show description for 598325d
  wjwwood

  committed
  598325d

• style

  Show description for 6b14049
  wjwwood

  committed
  6b14049

• do not use const reference when it's a primitive (like bool)

  Show description for 46c207f
  wjwwood

  committed
  46c207f

• typo

  Show description for 8e28200
  wjwwood

  committed
  8e28200

Commits on Feb 23, 2019

• follow to bool change that wasn't staged

  Show description for 5273ad9
  wjwwood

  committed
  5273ad9

• fixup tests

  Show description for 06ddfc4
  wjwwood

  committed
  06ddfc4

Commits on Apr 10, 2019

• added lots of docs, alternative API signatures, and some of the tests

  Show description for 04f812c
  wjwwood

  committed
  04f812c

Commits on Apr 11, 2019

• more tests and associated fixes

  Show description for 206ffe3
  wjwwood

  committed
  206ffe3

Commits on Apr 12, 2019

• address documentation feedback

  Show description for 89018de
  wjwwood

  committed
  89018de

Commits on Apr 15, 2019

• fixup previously added tests

  Show description for 9e03b08
  wjwwood

  committed
  9e03b08

• add tests and fixes for describe_parameter(s) and get_parameter_types

  Show description for ac1b6a6
  wjwwood

  committed
  ac1b6a6

Commits on Apr 16, 2019

• remove old parameter tests

  Show description for 73b4c28
  wjwwood

  committed
  73b4c28

• use const reference where possible

  Show description for 78a94d9
  wjwwood

  committed
  78a94d9

• address comments

  Show description for bf1d149
  wjwwood

  committed
  bf1d149

• fix tests for deprecated methods

  Show description for 00da0a6
  wjwwood

  committed
  00da0a6

Commits on Apr 17, 2019

• address feedback

  Show description for 570c7c2
  wjwwood

  committed
  570c7c2

Commits on Apr 18, 2019

• significantly improve the reliability of the time_source tests

  Show description for 3ef385d
  wjwwood

  committed
  3ef385d

• uncrustify, cpplint, and cppcheck fixes

  Show description for 01362ff
  wjwwood

  committed
  01362ff

• Revert "significantly improve the reliability of the time_source tests"

  Show description for c48db2d
  wjwwood

  committed
  c48db2d

• Merge remote-tracking branch 'origin/master' into read_only_parameters

  wjwwood

  committed
  4673ce9

• only declare use_sim_time parameter if not already declared

  Show description for ce9af32
  wjwwood

  committed
  ce9af32

Commits on Apr 19, 2019

• fixup rclcpp_lifecycle

  Show description for fb78acd
  wjwwood

  committed
  fb78acd

• fixup tests

  Show description for b7e4c0d
  wjwwood

  committed
  b7e4c0d

• add missing namespace scope which fails on Windows

  Show description for efb3f85
  wjwwood

  committed
  efb3f85

• extend deprecation warning suppression to support Windows too

  Show description for 4ba4eeb
  wjwwood

  committed
  4ba4eeb

• fix compiler warnings and missing visibility macro

  Show description for cb72e58
  wjwwood

  committed
  cb72e58

• remove commented left over tests

  Show description for 7e79bba
  wjwwood

  committed
  7e79bba

• fix compiler warning on Windows

  Show description for 933ac09
  wjwwood

  committed
  933ac09

• suppress deprecation warning on include of file in Windows

  Show description for 444de25
  wjwwood

  committed
  444de25

• avoid potential loss of data warning converting int64_t to int

  Show description for df7b036
  wjwwood

  committed
  df7b036

Commits on Apr 22, 2019

• trying to fix more loss of data warnings

  Show description for ea3285f
  wjwwood

  committed
  ea3285f

• fix test_node

  Show description for 68a4afe
  wjwwood

  committed
  68a4afe

Commits on Apr 23, 2019

• add option to automatically declare parameters from initial parameters (yaml file)

  Show description for d9ad096
  wjwwood

  committed
  d9ad096

• remove redundant conditional

  Show description for e29cdf1
  wjwwood

  committed
  e29cdf1