Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual destructors to classes with virtual functions. #566

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Add virtual destructors to classes with virtual functions. #566

merged 1 commit into from
Oct 8, 2018

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Oct 5, 2018 •
edited
Loading

This fixes the build on MacOS High Sierra and later, and
is the more correct thing to do anyway.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

fixes #563

@clalancette
Add virtual destructors to classes with virtual functions.
2987611 
This fixes the build on MacOS High Sierra and later, and
is the more correct thing to do anyway.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette added the in progress Actively being worked on (Kanban column) label Oct 5, 2018
@clalancette
Copy link
Contributor Author

clalancette commented Oct 5, 2018 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Oct 6, 2018
This was referenced Oct 8, 2018
Merged
Closed
@clalancette clalancette merged commit bedb3ae into master Oct 8, 2018
@clalancette clalancette deleted the fix-virtual-destructors branch October 8, 2018 15:02
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Oct 8, 2018
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
@mjeronimo
Prepare 0.4.0 (ros2#566)
3d874af 
* Update changelogs and setup.py

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>

* Update versions in new packages to match (so that we can run bloom)

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>

* 0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing virtual destructors on Apple Clang version 10.0
2 participants
@clalancette @dirk-thomas