Ensure all Clock accesses are thread-safe #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
changed the title
|
It would be good to keep these two changes (PIMPL and adding a mutex) separate since together in a single commit it just makes the review harder. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/clock-thread-safety
branch
from
2375505
to
f4ff7f1
Compare
|
@dirk-thomas fair enough, see a91ba82 and f4ff7f1. |
clalancette
added a commit
that referenced
this pull request
Feb 21, 2020
This is an alternative PR to #999 The code in this one is less nice, but it is ABI-safe. Thus, it can be used as a short-term workaround for users hurt by the problem now, and/or used as the solution for Eloquent. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
dirk-thomas
approved these changes
Feb 21, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/clock-thread-safety
branch
from
f4ff7f1
to
79455ee
Compare
|
CI up to
|
clalancette
approved these changes
Feb 26, 2020
|
Alright, going in! |
clalancette
added a commit
that referenced
this pull request
Apr 9, 2020
This is an alternative PR to #999 The code in this one is less nice, but it is ABI-safe. Thus, it can be used as a short-term workaround for users hurt by the problem now, and/or used as the solution for Eloquent. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Apr 9, 2020
This is an alternative PR to #999 The code in this one is less nice, but it is ABI-safe. Thus, it can be used as a short-term workaround for users hurt by the problem now, and/or used as the solution for Eloquent. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Jun 16, 2020
This is an alternative PR to #999 The code in this one is less nice, but it is ABI-safe. Thus, it can be used as a short-term workaround for users hurt by the problem now, and/or used as the solution for Eloquent. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. Before this patch, both
rclcpp::Clockandrclcpp::TimerBase(though indirectly throughrcl) would access non thread-safercl_clock_*API without locking, leading to internal state corruption on concurrent access in multi-threaded applications.This change is ABI breaking w.r.t. to previous distro releases (e.g. Eloquent) but sets the scene for future non ABI breaking changes using a PIMPL.