Included tl_expected #185
Merged
Included tl_expected #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This was referenced Feb 2, 2024
clalancette
requested changes
Feb 2, 2024
CMakeLists.txt
Outdated
| @@ -50,14 +51,41 @@ ament_export_dependencies(rcutils) | |||
|
|
|||
| if(BUILD_TESTING) | |||
| find_package(ament_cmake_gtest REQUIRED) | |||
| find_package(ament_lint_auto REQUIRED) | |||
| # find_package(ament_lint_auto REQUIRED) | |||
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
|
@clalancette can we also backport this to |
|
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 2a5bfd5) # Conflicts: # CMakeLists.txt
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 2a5bfd5)
ahcorde
added a commit
that referenced
this pull request
Feb 8, 2024
ahcorde
pushed a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with this other PR ros2/ros2#1516
The idea is to include tl_expected in rclcpp until the standard CXX20 is available in the ros distribution
FYI @tylerjw