Fix parent_path() for empty paths and paths of length one #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies the expected output for empty, current, and parent paths. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
In this case, return an empty path. Previously, this would result in a segmentation fault. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Karsten1987
reviewed
Jun 18, 2020
jacobperron
commented
Jun 18, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
wjwwood
approved these changes
Jun 18, 2020
|
Testing rcpputils:
|
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Fixed expected output syntax on Windows: a2edff8
|
jacobperron
force-pushed
the
jacob/parent_path_exists
branch
from
209851b
to
2035cd9
Compare
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/parent_path_exists
branch
from
2035cd9
to
cf12223
Compare
|
Windows paths were trickier than I anticipated.
@Karsten1987 @wjwwood Can you take another look? Thanks! |
wjwwood
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly unrelated, but this PR also adds tests for
exists()to clarify it's expected behavior (36ebd99).This fixes an issue discovered downstream: https://github.com/ros2/rosbag2/pull/345/files#r442416506