code style only: wrap after open parenthesis if not in one line #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
wjwwood
approved these changes
Jan 31, 2020
delete-merged-branch
bot
deleted the
dirk-thomas/nl_func_call_start_multi_line
branch
wjwwood
reviewed
Feb 6, 2020
| @@ -102,7 +105,8 @@ TEST_F(TestTimeFixture, test_rcutils_steady_time_now) { | |||
| std::this_thread::sleep_for(std::chrono::milliseconds(100)); | |||
| // Then take a new timestamp with each and compare. | |||
| rcutils_time_point_value_t later; | |||
| EXPECT_NO_MEMORY_OPERATIONS({ | |||
| EXPECT_NO_MEMORY_OPERATIONS( | |||
| { | |||
There was a problem hiding this comment.
Btw, these are actually wrong. This should become:
EXPECT_NO_MEMORY_OPERATIONS(
{
ret = rcutils_steady_time_now(&later);
});Because if you replaced the first argument with a variable name it would be:
EXPECT_NO_MEMORY_OPERATIONS(
argument);And not this:
EXPECT_NO_MEMORY_OPERATIONS(
argument);There was a problem hiding this comment.
I don't disagree. This is just what uncrustify can do atm. The options are simple:
- report the problem upstream (or even better contribute a PR to support this in the way we want it)
- change the configuration options we use which seems to sacrifice other parts of the style
- not use
uncrustifyat all if we are unhappy with what it does and just not enforce that level of style
There was a problem hiding this comment.
I know, but I was just pointing it out in case we revisit this in the future. I don't care for the new state, but have time to argue to change it back or fix uncrustify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style update to match the ROS 2 development guide and pass with the updated linter configuration from ament/ament_lint#210.