Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected publish calls with shared_ptr signature #75

Closed
wants to merge 4 commits into from
Closed

Corrected publish calls with shared_ptr signature #75

wants to merge 4 commits into from

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Apr 29, 2019 •
edited by wjwwood
Loading

See ros2/rclcpp#709

I deleted allocator_shared_ptr test because it doesn't have more sense.
I'm not sure about allocator_example.

@ivanpauno
Corrected publish calls with shared_ptr signature
ba77cb5 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Apr 29, 2019
@ivanpauno
Changed publish call with unique_ptr signature
08c6461 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Corrected linter failure
7186777 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Corrected allocator_examples
c25a1f6 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
sloretz
sloretz approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about allocators, but reading a bunch of cppreference pages I'm pretty sure this is OK.

It would be nice if rclcpp had a utility for making a unique_ptr to a message using an allocator.

@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 2, 2019
@wjwwood
Copy link
Member

wjwwood commented May 5, 2019

Closing in favor of #76 which is not on a fork (for easier testing).

@wjwwood wjwwood closed this May 5, 2019
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivanpauno @wjwwood @mjcarroll @sloretz @tfoote