Add specific return type for non existent node #182
Conversation
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
rmw/include/rmw/ret_types.h
Outdated
| @@ -36,6 +36,10 @@ typedef int32_t rmw_ret_t; | |||
| /// Incorrect rmw implementation. | |||
| #define RMW_RET_INCORRECT_RMW_IMPLEMENTATION 12 | |||
|
|
|||
| // rmw node specific ret codes in 2XX | |||
| /// Failed to find node name | |||
| #define RMW_RET_NON_EXISTENT_NODE_NAME 203 | |||
There was a problem hiding this comment.
Why 203 instead of maybe 20?
There was a problem hiding this comment.
I found the matching define in rcl so this number makes sense. Maybe mention rcl in the existing comment.
There was a problem hiding this comment.
Does it matter if they're matching? There's a convert function anyway.
Seems arbitrary to me.
There was a problem hiding this comment.
Also, I think the name needs to be updated according to ros2/rcl#492 (comment)
- RMW_RET_NON_EXISTENT_NODE_NAME
+ RMW_RET_NODE_NAME_NON_EXISTENTThere was a problem hiding this comment.
Does it matter if they're matching? There's a convert function anyway.
Seems arbitrary to me.
It's arbitrary yes, but I think it have some sense.
Also, I think the name needs to be updated according to ros2/rcl#492 (comment)
- RMW_RET_NON_EXISTENT_NODE_NAME + RMW_RET_NODE_NAME_NON_EXISTENT
Thanks, forgot to push that commit.
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
| @@ -36,6 +36,11 @@ typedef int32_t rmw_ret_t; | |||
| /// Incorrect rmw implementation. | |||
| #define RMW_RET_INCORRECT_RMW_IMPLEMENTATION 12 | |||
|
|
|||
| // rmw node specific ret codes in 2XX | |||
| /// Failed to find node name | |||
| // Using same return code than in rcl | |||
There was a problem hiding this comment.
I prefer using the same code when possible, I don't think it's important
delete-merged-branch
bot
deleted the
ivanpauno/add-error-for-non-existent-node
branch
Addresses ros2/ros2cli#322 (comment)