-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rmw_*_event_init() functions to rmw_implementation #202
Conversation
Signed-off-by: Miaofei <miaofei@amazon.com>
…ation Signed-off-by: Miaofei <miaofei@amazon.com>
The full set of related pull requests are the following:
( |
@ivanpauno and @wjwwood, can we kick off CI and see if these changes are ready to be merged? |
Sure thing (try to provide a gist for this cases): |
Sorry! Will do next time! |
Does it look like we can merge this set of pull requests? |
I will rerun linux CI job that failed randomly: Most of the failures in Windows should been fixed after ros2/launch#391, the others seem random flaky tests failing. Re-running to check: |
@ivanpauno, it looks like the Linux build randomly failed again. Also, the test failures on Windows look unrelated. |
Related to ros2/ros2#822
This moves the
rmw_publisher_event_init()
andrmw_subscription_event_init()
functions intormw_implementation
so that they will be able to check for whether or not the given type ofrmw_event_type_t
is supported by the chosen middleware.