Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

catch error before nullptr access segfault #239

Merged
merged 1 commit into from
Jul 20, 2017
Merged

catch error before nullptr access segfault #239

merged 1 commit into from
Jul 20, 2017

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Jul 14, 2017

Found this while investigating #234

@wjwwood wjwwood added the enhancement New feature or request label Jul 14, 2017
@wjwwood wjwwood self-assigned this Jul 14, 2017
@wjwwood wjwwood added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 14, 2017
dirk-thomas
dirk-thomas approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Waiting with merge until after #237.

@dirk-thomas dirk-thomas merged commit 7b557ab into master Jul 20, 2017
@dirk-thomas dirk-thomas deleted the fix_segfault_on_narrow_fail branch July 20, 2017 21:18
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jul 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@wjwwood wjwwood

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjwwood @dirk-thomas