Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

pass context to wait set and fini context #343

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Jan 10, 2019

Connects to ros2/rmw#163

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Jan 10, 2019
@wjwwood wjwwood self-assigned this Jan 10, 2019
@wjwwood
Copy link
Member Author

wjwwood commented Jan 24, 2019

I still need a review on this pr (and one other ros2/rmw_fastrtps#252), if anyone has time.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one minor comment.

rmw_connext_shared_cpp/src/wait_set.cpp Outdated Show resolved Hide resolved
@wjwwood wjwwood merged commit 937432d into master Jan 25, 2019
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jan 25, 2019
@wjwwood wjwwood deleted the context_followup_2 branch January 25, 2019 03:44
dabonnie pushed a commit to aws-ros-dev/rmw_connext that referenced this pull request Apr 3, 2019
* pass context to wait set and fini context

Signed-off-by: William Woodall <william@osrfoundation.org>

* use nullptr in C++

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants