Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDS_TIME_INVALID and DDS_Time_is_invalid for connext micro #140

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

cwecht
Copy link
Contributor

@cwecht cwecht commented Feb 6, 2024

For whatever reasons ConnextDDS micro exports DDS_TIME_INVALID but it doesn't define it. Therefore this results in a runtime error - because during runtime as the shared library is loaded, the symbol to DDS_TIME_INVALID can not be resolved.

Also DDS_Time_is_invalid is not defined. So both need to be added in order to make rmw_connextmicro work.

Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
@cwecht
Copy link
Contributor Author

cwecht commented Feb 13, 2024

This PR is basically a direct follow up to #120. At the time I only checked whether rmw_connextmicro build successfully. Later I discuvered this issue with Connext Micro exporting symbols which it doesn't define.

@asorbini it would be great if you could have a look at this.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwecht it really looks like the problem is with ConnextDDS micro where it should address your issue here? Having the work-around to bypass the problem would be unexpected behavior in the future, since all these definition need to be in the DDS implementation?

@asorbini it would be appreciated if you can chime in here.

@cwecht
Copy link
Contributor Author

cwecht commented Feb 14, 2024

@asorbini I found neither for ConnextDDS Micro 3.0.3.28 nor for 2.4.13.4 any definition for DDS_TIME_INVALID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants