-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "Failed to parse type hash" message was overly spammy [ros2-50] #149
Conversation
Signed-off-by: Taxo Rubio <trubio@rti.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI.
In 🧇 meeting we talked about taking this change and also adding a "log once". The log once call would say there was a type mismatch, and tell users to switch the logging mode to debug to see more info. Looking closer I now see that this is using an rmw_connext specific logging macro, and there's no log-once equivalent. @clalancette what do you think about taking this change as-is? |
The CI jobs have expired, I'm running them again: Regarding @sloretz's comment, we can file a task to add the log-once feature but I prefer to keep it out of this PR to avoid feature creeping. |
@clalancette We are ready to merge this PR, but we have a couple of questions:
Based on your answers we might have to update (and re-run CI as a formality) before merging. Thank you for your help! |
Pulls: #149 |
No, we never use Merge commits in the final commit. That said, using the "Squash and merge" button in GitHub should always do the right thing, which is what we use everywhere else. That said, it looks like CI on this change wasn't completely run, so I ran it again. |
@clalancette A friendly ping to follow up |
CI is ok, as we don't run for ARM or RHEL |
Having this message printed with too high of a verbosity level makes it too spammy in normal executions of the RMW, making it hard to work with the log files.