Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create branch foxy to support Foxy #16

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Create branch foxy to support Foxy #16

merged 4 commits into from
Mar 29, 2021

Conversation

asorbini
Copy link
Collaborator

This PR updates branch foxy (branched from 27764f3) to make it buildable only with the Foxy release.

The PR removes all "feature flags" from static_config.hpp, including RMW_CONNEXT_RELEASE and any code meant to support earlier (and later) releases.

The code was changed assuming the following "feature configuration":

Feature Value
RMW_CONNEXT_RELEASE RMW_CONNEXT_RELEASE_FOXY
RMW_CONNEXT_HAVE_PKG_RMW_DDS_COMMON 1
RMW_CONNEXT_HAVE_SCOPE_EXIT 0
RMW_CONNEXT_HAVE_GET_DOMAIN 0
RMW_CONNEXT_HAVE_OPTIONS 1
RMW_CONNEXT_HAVE_OPTIONS_PUBSUB 1
RMW_CONNEXT_HAVE_INCOMPATIBLE_QOS 0
RMW_CONNEXT_HAVE_INCOMPATIBLE_QOS_EVENT 1
RMW_CONNEXT_HAVE_LIFESPAN_QOS 0
RMW_CONNEXT_HAVE_MESSAGE_LOST 0
RMW_CONNEXT_HAVE_SERVICE_INFO 1
RMW_CONNEXT_HAVE_LOCALHOST_ONLY 1
RMW_CONNEXT_HAVE_TAKE_SEQ 1
RMW_CONNEXT_HAVE_SECURITY 1
RMW_CONNEXT_HAVE_COMMON_MUTEX 1
RMW_CONNEXT_HAVE_LOAN_MESSAGE 1
RMW_CONNEXT_HAVE_MESSAGE_INFO_TS 1
RMW_CONNEXT_HAVE_GET_INFO_BY_TOPIC 1
RMW_CONNEXT_HAVE_QOS_PROFILE_API 0
RMW_CONNEXT_HAVE_TIME_UTILS 0

Note to reviewers: It would be great to review these changes but they are somewhat trivial. I'm creating this PR mainly to keep track of them for future reference.

Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
@asorbini
Copy link
Collaborator Author

asorbini commented Mar 26, 2021

CI jobs to validate the changes (note: first time running unit tests for Foxy 🤞🏼):

  • ci_linux: Build Status
  • ci_osx:
    • Build Status Build Status (rmw_connext_cpp excluded)
    • Build Status (up to rmw_connextdds only)
  • ci_windows:
    • Build Status (rmw_connext_cpp excluded)
    • Build Status (up to rmw_connextdds only)
    • Build Status (up to rmw_connextdds only)

Signed-off-by: Andrea Sorbini <asorbini@rti.com>
@asorbini asorbini merged commit 3004323 into foxy Mar 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the asorbini/foxy-no-ff branch March 29, 2021 20:26
@asorbini asorbini added the foxy PR pertaining the Foxy release label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foxy PR pertaining the Foxy release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant