Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a list instead of a set for node names list #112

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Use a list instead of a set for node names list #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rmw_cyclonedds_cpp/src/rmw_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2884,14 +2884,14 @@ extern "C" rmw_ret_t rmw_get_node_names(
return RMW_RET_ERROR;
}

std::set<std::pair<std::string, std::string>> ns;
std::vector<std::pair<std::string, std::string>> ns;
const auto re = std::regex("^name=(.*);namespace=(.*);$", std::regex::extended);
auto oper =
[&ns, re](const dds_builtintopic_participant_t & sample, const char * ud) -> bool {
std::cmatch cm;
static_cast<void>(sample);
if (std::regex_search(ud, cm, re)) {
ns.insert(std::make_pair(std::string(cm[1]), std::string(cm[2])));
ns.push_back(std::make_pair(std::string(cm[1]), std::string(cm[2])));
}
return true;
};
Expand Down