Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build warnings #162

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Fix build warnings #162

merged 2 commits into from
Apr 22, 2020

Conversation

ivanpauno
Copy link
Member

Fixes #145 (comment).

  • Linux Build Status

@ivanpauno
Fix build warnings
16f1ef7 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Please linters
8bcec65 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added bug Something isn't working in review labels Apr 22, 2020
@ivanpauno ivanpauno self-assigned this Apr 22, 2020
@dirk-thomas
Copy link
Member

The custom GitHub action is already failing on the target branch.

@ivanpauno
Copy link
Member Author

ivanpauno commented Apr 22, 2020 •
edited
Loading

Failures on Windows checks aren't related, merging!

@ivanpauno ivanpauno merged commit 0fc4a3f into master Apr 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-build-warnings branch April 22, 2020 22:40
@rotu
Copy link
Collaborator

rotu commented Apr 22, 2020 •
edited
Loading

Created eProsima/Fast-DDS#1173 as Fast-RTPS seems to have broken the build

@wjwwood wjwwood mentioned this pull request Apr 22, 2020
Merged
@eboasson
Copy link
Collaborator

Thanks @ivanpauno ☺️

@ivanpauno ivanpauno mentioned this pull request Apr 29, 2020
Closed
@ivanpauno ivanpauno restored the ivanpauno/fix-build-warnings branch April 30, 2020 15:56
@ivanpauno ivanpauno deleted the ivanpauno/fix-build-warnings branch April 30, 2020 16:19
@ivanpauno ivanpauno restored the ivanpauno/fix-build-warnings branch April 30, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@sloretz sloretz sloretz approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@ivanpauno ivanpauno

Labels
bug Something isn't working in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivanpauno @dirk-thomas @rotu @eboasson @sloretz