Fix that not to delete some objects after destroying functions #236

iuhilnehc-ynos · 2020-09-04T02:44:32Z

Fixes #235

Signed-off-by: Chen.Lihui lihui.chen@sony.com

Signed-off-by: Chen.Lihui <lihui.chen@sony.com>

rmw_cyclonedds_cpp/src/rmw_node.cpp

fujitatomoya · 2020-09-05T12:23:45Z

@iuhilnehc-ynos

besides, cppcheck looks unhappy for windows and macOS. could you look into it?

iuhilnehc-ynos · 2020-09-06T13:32:18Z

@fujitatomoya

@iuhilnehc-ynos

besides, cppcheck looks unhappy for windows and macOS. could you look into it?

I encounter that before (in some previous PR), but It seems that maintainers not decide to deal with them.

Such as,

  [7.801s] 2: [src/rmw_node.cpp:704]: (error: unknownMacro) There is an unknown macro here somewhere. Configuration is required. If RCUTILS_STRINGIFY is a macro then please configure it.

rmw_cyclonedds/rmw_cyclonedds_cpp/src/rmw_node.cpp

Line 704 in 4fc5de7

RCUTILS_STRINGIFY(__FILE__) ":" RCUTILS_STRINGIFY(__function__) ":"

eboasson · 2020-09-06T13:56:42Z

@fujitatomoya

@iuhilnehc-ynos
besides, cppcheck looks unhappy for windows and macOS. could you look into it?

I encounter that before (in some previous PR), but It seems that maintainers not decide to deal with them.

It isn't being ignored so much as that cppcheck is disagreeing with correct code and fixing it turns out to not be so trivial (see #220).

And @iuhilnehc-ynos and @fujitatomoya thank you for all the work! I look forward to the final touches on the PR so that it can be merged.

Signed-off-by: Chen.Lihui <lihui.chen@sony.com> Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

iuhilnehc-ynos · 2020-09-07T01:24:37Z

@eboasson

It isn't being ignored so much as that cppcheck is disagreeing with correct code and fixing it turns out to not be so trivial (see #220).

Thanks for your information. I'll also keep my eyes on it and try to get a method to fix it.
(I don't know if ivanpauno will accept the solution about --suppress=unknownMacro)

iuhilnehc-ynos · 2020-09-07T01:28:50Z

@fujitatomoya

Could you review it again?
NOTE: Do you know why I can't use Re-request review link for you?

fujitatomoya

LGTM

fujitatomoya · 2020-09-07T03:52:20Z

Do you know why I can't use Re-request review link for you?

No idea, sorry...

iuhilnehc-ynos · 2020-09-07T14:27:06Z

I don't know if we need to explicitly add rcutils path to '--include_dirs' for cppcheck.

debug log

chenlh@lihuideMacBook-Pro rmw_cyclonedds_cpp % cd /Users/chenlh/Projects/ROS2/src/ros2/rmw_cyclonedds/rmw_cyclonedds_cpp

chenlh@lihuideMacBook-Pro rmw_cyclonedds_cpp % /Users/chenlh/Projects/ROS2/install/ament_cppcheck/bin/ament_cppcheck --xunit-file /Users/chenlh/Projects/ROS2/build/rmw_cyclonedds_cpp/test_results/rmw_cyclonedds_cpp/cppcheck.xunit.xml --include_dirs /Users/chenlh/Projects/ROS2/src/ros2/rmw_cyclonedds/rmw_cyclonedds_cpp/include
[src/rmw_node.cpp:713]: (error: unknownMacro) There is an unknown macro here somewhere. Configuration is required. If RCUTILS_STRINGIFY is a macro then please configure it.
1 errors

chenlh@lihuideMacBook-Pro rmw_cyclonedds_cpp % /Users/chenlh/Projects/ROS2/install/ament_cppcheck/bin/ament_cppcheck --xunit-file /Users/chenlh/Projects/ROS2/build/rmw_cyclonedds_cpp/test_results/rmw_cyclonedds_cpp/cppcheck.xunit.xml --include_dirs /Users/chenlh/Projects/ROS2/src/ros2/rmw_cyclonedds/rmw_cyclonedds_cpp/include /Users/chenlh/Projects/ROS2/src/ros2/rcutils/include
No problems found

patch as following,

diff --git a/rmw_cyclonedds_cpp/CMakeLists.txt b/rmw_cyclonedds_cpp/CMakeLists.txt
index 480f1ac..08b0da0 100644
--- a/rmw_cyclonedds_cpp/CMakeLists.txt
+++ b/rmw_cyclonedds_cpp/CMakeLists.txt
@@ -105,6 +105,7 @@ register_rmw_implementation(

 if(BUILD_TESTING)
   find_package(ament_lint_auto REQUIRED)
+  set(ament_cmake_cppcheck_ADDITIONAL_INCLUDE_DIRS ${rcutils_INCLUDE_DIRS})
   ament_lint_auto_find_test_dependencies()
 endif()

iuhilnehc-ynos · 2020-09-07T22:15:56Z

macOS

chenlh@lihuideMacBook-Pro rmw_cyclonedds % /usr/local/bin/cppcheck --version
Cppcheck 2.1
chenlh@lihuideMacBook-Pro rmw_cyclonedds % /usr/local/bin/cppcheck -f --inline-suppr -q -rp --suppress=internalAstError -I /Users/chenlh/Projects/ROS2/src/ros2/rmw_cyclonedds/rmw_cyclonedds_cpp/include rmw_cyclonedds_cpp/src/rmw_node.cpp
rmw_cyclonedds_cpp/src/rmw_node.cpp:713:41: error: There is an unknown macro here somewhere. Configuration is required. If RCUTILS_STRINGIFY is a macro then please configure it. [unknownMacro]
        RCUTILS_STRINGIFY(__FILE__) ":" RCUTILS_STRINGIFY(__function__) ":"

ubuntu

chenlh@OptiPlex-7050:~/Projects/ROS2/ros2_ws_master/src/ros2/rmw_cyclonedds$ /usr/bin/cppcheck --version
Cppcheck 1.90
chenlh@OptiPlex-7050:~/Projects/ROS2/ros2_ws_master/src/ros2/rmw_cyclonedds$ /usr/bin/cppcheck -f --inline-suppr -q -rp  --suppress=internalAstError -I /home/chenlh/Projects/ROS2/ros2_ws_master/src/ros2/rmw_cyclonedds/rmw_cyclonedds_cpp/include rmw_cyclonedds_cpp/src/rmw_node.cpp
chenlh@OptiPlex-7050:~/Projects/ROS2/ros2_ws_master/src/ros2/rmw_cyclonedds$

Next step, I think I need to check cppcheck not ament_cppcheck

iuhilnehc-ynos · 2020-09-08T00:39:58Z

After using cppcheck(2.1) at ubuntu, it failed with the same error(unknownMacro), I believe that using concrete "-I path" for cppcheck is a feature of v2.1 compared with v1.9. (Sorry about not looking into cppcheck source.) So the patch about using 'set(ament_cmake_cppcheck_ADDITIONAL_INCLUDE_DIRS ${rcutils_INCLUDE_DIRS})' in CMakeLists.txt seems one solution. (Why not updating ament_lint_auto_find_test_dependencies to add all INCLUDE_DIRS for ament_cppcheck automatically at internal? ament/ament_lint#265 is a better idea.)

About unknownMacro issue, it's better to fix on #220 .

clalancette · 2020-09-08T12:41:34Z

After using cppcheck(2.1) at ubuntu, it failed with the same error(unknownMacro), I believe that using concrete "-I path" for cppcheck is a feature of v2.1 compared with v1.9. (Sorry about not looking into cppcheck source.)

Note that we have an overall problem with cppcheck 2.1: ros2/ros2#942 . Because of that, we are currently pinned to cppcheck 1.9 on all platforms.

iuhilnehc-ynos · 2020-09-08T14:35:19Z

pinned to cppcheck 1.9

That's good to know.

iuhilnehc-ynos · 2020-09-09T04:54:27Z

@eboasson

I look forward to the final touches on the PR so that it can be merged.

Could you please review it? (I hope you got a happy mood.)

eboasson

Hi @iuhilnehc-ynos there are three things:

I am embarrassed by the number of memory leaks
In the long run, it would probably be worth it to rely more heavily on unique_ptrs
And there's one thing I suggest changing in the PR, it doesn't actually fix anything but I think it may help in the future.

Thank you!

rmw_cyclonedds_cpp/src/rmw_node.cpp

Signed-off-by: Chen.Lihui <lihui.chen@sony.com> Co-authored-by: eboasson <eb@ilities.com>

iuhilnehc-ynos · 2020-09-09T09:45:39Z

@eboasson

In the long run, it would probably be worth it to rely more heavily on unique_ptrs

I used the unique_ptr if it could be.

there's one thing I suggest changing in the PR

After using unique_ptr, it seems not necessary to change with the suggestion.

Could you please review it again? Thank you.

eboasson

@iuhilnehc-ynos it looks good to me, thank you! @ivanpauno or @hidmic I'd appreciate it if you could take a final look because I don't quite trust myself with C++ just yet ...

ivanpauno

lgtm with one minor question

rmw_cyclonedds_cpp/src/rmw_node.cpp

Signed-off-by: Chen.Lihui <lihui.chen@sony.com>

ivanpauno · 2020-09-11T19:45:57Z

CI:

Linux
Linux-aarch64
macOS
Windows

) Signed-off-by: Chen.Lihui <lihui.chen@sony.com>

Fix that not to delete some objects after destroying functions

4fc5de7

Signed-off-by: Chen.Lihui <lihui.chen@sony.com>

fujitatomoya requested changes Sep 5, 2020

View reviewed changes

rmw_cyclonedds_cpp/src/rmw_node.cpp Outdated Show resolved Hide resolved

rmw_cyclonedds_cpp/src/rmw_node.cpp Show resolved Hide resolved

rmw_cyclonedds_cpp/src/rmw_node.cpp Show resolved Hide resolved

avoid double free

def772c

Signed-off-by: Chen.Lihui <lihui.chen@sony.com> Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

fujitatomoya approved these changes Sep 7, 2020

View reviewed changes

eboasson reviewed Sep 9, 2020

View reviewed changes

rmw_cyclonedds_cpp/src/rmw_node.cpp Outdated Show resolved Hide resolved

Use unique_ptr for CddsCS

6e20e18

Signed-off-by: Chen.Lihui <lihui.chen@sony.com> Co-authored-by: eboasson <eb@ilities.com>

iuhilnehc-ynos requested a review from eboasson September 9, 2020 08:15

eboasson approved these changes Sep 9, 2020

View reviewed changes

ivanpauno approved these changes Sep 9, 2020

View reviewed changes

rmw_cyclonedds_cpp/src/rmw_node.cpp Outdated Show resolved Hide resolved

Keep same destroy behavior for data with [client/service]_name

04bf5bd

Signed-off-by: Chen.Lihui <lihui.chen@sony.com>

iuhilnehc-ynos requested a review from ivanpauno September 10, 2020 10:16

ivanpauno approved these changes Sep 11, 2020

View reviewed changes

ivanpauno merged commit 4a5b645 into ros2:master Sep 11, 2020

Barry-Xu-2018 mentioned this pull request Sep 23, 2020

memory leaks in rcl(tests) ros2/rcl#721

Closed

eboasson pushed a commit to eboasson/rmw_cyclonedds that referenced this pull request May 17, 2021

Fix that not to delete some objects after destroying functions (ros2#236

4183190

) Signed-off-by: Chen.Lihui <lihui.chen@sony.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix that not to delete some objects after destroying functions #236

Fix that not to delete some objects after destroying functions #236

iuhilnehc-ynos commented Sep 4, 2020 •

edited

Loading

fujitatomoya commented Sep 5, 2020

iuhilnehc-ynos commented Sep 6, 2020

eboasson commented Sep 6, 2020

iuhilnehc-ynos commented Sep 7, 2020 •

edited

Loading

iuhilnehc-ynos commented Sep 7, 2020 •

edited

Loading

fujitatomoya left a comment

fujitatomoya commented Sep 7, 2020

iuhilnehc-ynos commented Sep 7, 2020 •

edited

Loading

iuhilnehc-ynos commented Sep 7, 2020

iuhilnehc-ynos commented Sep 8, 2020 •

edited

Loading

clalancette commented Sep 8, 2020

iuhilnehc-ynos commented Sep 8, 2020

iuhilnehc-ynos commented Sep 9, 2020

eboasson left a comment

iuhilnehc-ynos commented Sep 9, 2020

eboasson left a comment

ivanpauno left a comment

ivanpauno commented Sep 11, 2020

Fix that not to delete some objects after destroying functions #236

Fix that not to delete some objects after destroying functions #236

Conversation

iuhilnehc-ynos commented Sep 4, 2020 • edited Loading

fujitatomoya commented Sep 5, 2020

iuhilnehc-ynos commented Sep 6, 2020

eboasson commented Sep 6, 2020

iuhilnehc-ynos commented Sep 7, 2020 • edited Loading

iuhilnehc-ynos commented Sep 7, 2020 • edited Loading

fujitatomoya left a comment

Choose a reason for hiding this comment

fujitatomoya commented Sep 7, 2020

iuhilnehc-ynos commented Sep 7, 2020 • edited Loading

iuhilnehc-ynos commented Sep 7, 2020

iuhilnehc-ynos commented Sep 8, 2020 • edited Loading

clalancette commented Sep 8, 2020

iuhilnehc-ynos commented Sep 8, 2020

iuhilnehc-ynos commented Sep 9, 2020

eboasson left a comment

Choose a reason for hiding this comment

iuhilnehc-ynos commented Sep 9, 2020

eboasson left a comment

Choose a reason for hiding this comment

ivanpauno left a comment

Choose a reason for hiding this comment

ivanpauno commented Sep 11, 2020

iuhilnehc-ynos commented Sep 4, 2020 •

edited

Loading

iuhilnehc-ynos commented Sep 7, 2020 •

edited

Loading

iuhilnehc-ynos commented Sep 7, 2020 •

edited

Loading

iuhilnehc-ynos commented Sep 7, 2020 •

edited

Loading

iuhilnehc-ynos commented Sep 8, 2020 •

edited

Loading