Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gid API return codes. #244

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Update gid API return codes. #244

merged 1 commit into from
Sep 22, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 21, 2020

To be compliant with the API spec. Connected to ros2/rmw#274.

@hidmic hidmic mentioned this pull request Sep 21, 2020
Merged
@hidmic
Copy link
Contributor Author

hidmic commented Sep 21, 2020 •
edited
Loading

CI up to test_rmw_implementation:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic mentioned this pull request Sep 22, 2020
Merged
Lobotuerk
Lobotuerk approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@Lobotuerk Lobotuerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic requested a review from ivanpauno September 22, 2020 15:30
@ivanpauno
Copy link
Member

CI up to test_rmw_implementation:

Consider running CI up to rcl

@hidmic
Copy link
Contributor Author

hidmic commented Sep 22, 2020 •
edited
Loading

CI up test_rmw_implementation and rcl:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Update gid API return codes.
e765bf0 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the hidmic/update-gid-api-ret branch from bc4d55f to e765bf0 Compare September 22, 2020 20:29
@hidmic
Copy link
Contributor Author

hidmic commented Sep 22, 2020

Had to rebase on top of #245. Third's the charm:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Sep 22, 2020

Alright, finally green. Going in!

@hidmic hidmic merged commit 243f521 into master Sep 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/update-gid-api-ret branch September 22, 2020 21:20
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
@hidmic @ahcorde
Update gid API return codes. (#244)
817f738 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 15, 2020
@hidmic @ahcorde
Update gid API return codes. (#244)
6bc75b4 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@Lobotuerk Lobotuerk Lobotuerk approved these changes

@eboasson eboasson Awaiting requested review from eboasson eboasson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @ivanpauno @Lobotuerk