Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array get_function semantics #248

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Sep 24, 2020

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the one inline comment this LGTM

@ivanpauno ivanpauno merged commit cbe0c8a into master Sep 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-array-get-function-semantics branch September 24, 2020 21:32
eboasson pushed a commit to eboasson/rmw_cyclonedds that referenced this pull request May 17, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants