Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return RMW_RET_UNSUPPORTED in rmw_get_serialized_message_size #250

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 28, 2020

Return the right error code. Related with ros2/rmw#281

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 29, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit f7b401e into master Sep 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/fix/rmw_get_serialized_message_size branch September 29, 2020 08:28
ahcorde added a commit that referenced this pull request Oct 9, 2020
ahcorde added a commit that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants