-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rmw_publisher_wait_for_all_acked support #294
Merged
ivanpauno
merged 1 commit into
ros2:master
from
Barry-Xu-2018:topic-wait_for_all_acked-feature
Jun 15, 2021
Merged
Add rmw_publisher_wait_for_all_acked support #294
ivanpauno
merged 1 commit into
ros2:master
from
Barry-Xu-2018:topic-wait_for_all_acked-feature
Jun 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboasson
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'll do the trick. LGTM!
fujitatomoya
approved these changes
Apr 1, 2021
Barry-Xu-2018
force-pushed
the
topic-wait_for_all_acked-feature
branch
from
April 16, 2021 09:37
fc27236
to
e65e103
Compare
Do rebase. |
ivanpauno
approved these changes
May 28, 2021
Barry-Xu-2018
force-pushed
the
topic-wait_for_all_acked-feature
branch
from
May 30, 2021 07:58
e65e103
to
ae7f348
Compare
Do rebase |
The failure is caused by build error
But codes aren't related to this change. |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
force-pushed
the
topic-wait_for_all_acked-feature
branch
from
June 15, 2021 05:16
ae7f348
to
d3af4f1
Compare
Tests were run in ros2/rmw#296 |
clalancette
pushed a commit
to eboasson/rmw_cyclonedds
that referenced
this pull request
May 18, 2022
Signed-off-by: Barry Xu <barry.xu@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ros2/rmw#295