Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new rmw_dds_common::get_security_files API. #323

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

clalancette
Copy link
Contributor

This gets rid of a bunch of custom code in rmw_cyclonedds_cpp.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This requires ros2/rmw_dds_common#51 to go in first.

This gets rid of a bunch of custom code in rmw_cyclonedds_cpp.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clalancette
Copy link
Contributor Author

CI in ros2/rmw_dds_common#51 (comment) was successful, so merging this.

@clalancette clalancette merged commit 0387cbf into master Jun 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the clalancette/common-security-files branch June 28, 2021 13:12
clalancette added a commit to eboasson/rmw_cyclonedds that referenced this pull request May 18, 2022
This gets rid of a bunch of custom code in rmw_cyclonedds_cpp.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants