Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill message info sequence numbers as unsupported, add rmw_feature_supported() implementation #381

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

ivanpauno
Copy link
Member

Related to ros2/rmw#318.

…pported() implementation

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Mar 11, 2022
@ivanpauno ivanpauno requested a review from wjwwood March 11, 2022 17:02
@ivanpauno ivanpauno self-assigned this Mar 11, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with CI

@ivanpauno ivanpauno merged commit 5fcd3ba into master Mar 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/add-sequence-numbers-to-message-info branch March 21, 2022 13:24
clalancette pushed a commit to eboasson/rmw_cyclonedds that referenced this pull request May 18, 2022
…pported() implementation (ros2#381)

* Fill message info sequence numbers as unsupported, add rmw_feature_supported() implementation

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants