-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rmw_cyclonedds] Improve handling of dynamic discovery #429
Conversation
…ion params Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-02-16/29927/1 |
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
EDIT seems to be solved by ros2/ros2#1402 @eboasson Any ideas why with automatic discovery range set to localhost, all these errors would show up on windows? The error
The number seems to vary, but the later tests have 119 ports tried, which seems to match the maximum participant index. It's almost like on Windows there's an issue sending the discovery packets to other potential participants. The job was built with the following commit with extra log messages in cyclone |
Signed-off-by: Shane Loretz <sloretz@google.com>
This PR adds to
rmw_cyclonedds
functionality necessary to support the improved handling of dynamic discovery.It adds handling of the new discovery parameters passed down from
rcl
.Current status: The desired functionality is only partially complete. Some of the entries in the goal matrix are not working correctly.