Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rmw_cyclonedds] Improve handling of dynamic discovery #429

Merged
merged 18 commits into from
Apr 8, 2023

Conversation

gbiggs
Copy link
Member

@gbiggs gbiggs commented Dec 14, 2022

This PR adds to rmw_cyclonedds functionality necessary to support the improved handling of dynamic discovery.

It adds handling of the new discovery parameters passed down from rcl.

Current status: The desired functionality is only partially complete. Some of the entries in the goal matrix are not working correctly.

…ion params

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-02-16/29927/1

mxgrey added 2 commits March 7, 2023 23:52
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
mxgrey and others added 2 commits March 21, 2023 13:33
rmw_cyclonedds_cpp/src/rmw_node.cpp Outdated Show resolved Hide resolved
rmw_cyclonedds_cpp/src/rmw_node.cpp Outdated Show resolved Hide resolved
rmw_cyclonedds_cpp/src/rmw_node.cpp Outdated Show resolved Hide resolved
sloretz added 2 commits March 29, 2023 00:29
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
@sloretz sloretz changed the title Improve handling of dynamic discovery - rmw_cyclonedds changes [rmw_cyclonedds] Improve handling of dynamic discovery Mar 29, 2023
sloretz added 8 commits March 29, 2023 23:36
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Shane Loretz <sloretz@google.com>
@sloretz
Copy link
Contributor

sloretz commented Apr 1, 2023

EDIT seems to be solved by ros2/ros2#1402

@eboasson Any ideas why with automatic discovery range set to localhost, all these errors would show up on windows? The error WSAEADDRNOTAVAIL shows up while cyclone is trying to send a UDP packet.

[test_subscriber-9] 1680304639.633310 [1]        tev: slortez: WSAEADDRNOTAVAIL (or fall through from WSAEFAULT)slortez: WSAEAFNOSUPPORT (or fall through from WSAEADDRNOTAVAIL)ddsi_udp_conn_write to udp/127.0.0.1:7660 failed with retcode -3

The number seems to vary, but the later tests have 119 ports tried, which seems to match the maximum participant index. It's almost like on Windows there's an issue sending the discovery packets to other potential participants.

The job was built with the following commit with extra log messages in cyclone
https://ci.ros2.org/job/ci_windows/19050/testReport/junit/(root)/projectroot/test_publisher_subscriber__rclpy__rmw_cyclonedds_cpp/

sloretz/cyclonedds@c1b549b

Signed-off-by: Shane Loretz <sloretz@google.com>
@sloretz sloretz merged commit 6510ad2 into rolling Apr 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the gbiggs/discovery-peers-specification branch April 8, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants