Add support for security logging plugin #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
If a `logging.xml` file is included in the security files, enable the security logging plugin in Fast RTPS using the properties contained in said file. Also reorganize existing security logic to be more testable, and add some tests for it. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
feature/dds-security-logging
branch
from
22f3116 to
ec4be2d
Compare
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
|
Let's go a simpler direction for Foxy. |
|
Replaced by #362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
logging.xmlfile is included in the security files, enable the security logging plugin in Fast RTPS using the properties contained in said file. Also reorganize existing security logic to be more testable, and add some tests for it.This PR is ready for review, but requires eProsima/Fast-DDS#1125, thus the draft status.