-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the MESSAGE_LOST event #581
Conversation
Fast-DDS (and rmw_fastrtps_cpp) don't really support this right now, but having it in the list here allows RViz2 to start up. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with green CI. Thanks @MiguelCompany !
@clalancette this test will fail unless we have a correct implementation for The only way to push this foward I can think of is to disable MESSAGE_LOST support on the CI, by putting this inside a Let me know what you think. |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Closed in favor of #583 |
This replaces #580 and adds proper support for MESSAGE_LOST event.
The interfaces are already present in Fast-DDS, but the listener callback is currently never called.
This means the RMW will behave as if messages are never lost, until we implement on_sample_lost on Fast DDS v2.6.0.