Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add line feed for RCUTILS_SAFE_FWRITE_TO_STDERR #608

Merged

Conversation

fujitatomoya
Copy link
Collaborator

related https://ci.ros2.org/job/ci_linux-aarch64/11327/testReport/projectroot.test/rclcpp/test_publisher/.

[ERROR] [1653330857.635679668] [ns.my_node.rclcpp]: Error in destruction of rcl publisher handle: Failed to delete datawriter, at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/src/ros2/rmw_fastrtps/rmw_fastrtps_shared_cpp/src/publisher.cpp:48, at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/src/ros2/rcl/rcl/src/rcl/publisher.c:187
Failed to delete dds publisher from participantFailed to delete participant[       OK ] TestPublisher.intra_process_publish_failures (11 ms)

Signed-off-by: Tomoya.Fujita Tomoya.Fujita@sony.com

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@MiguelCompany @ivanpauno minor fix, could you check?

Copy link
Collaborator

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

CI windows warnings are unrelated.

@fujitatomoya fujitatomoya merged commit 7202ceb into ros2:master Jun 6, 2022
@Blast545
Copy link
Contributor

👨‍🌾 This PR introduced a test regression in the fastrtps-dynamic nightlies jobs of the buildfarm, see:
Rci__nightly-fastrtps-dynamic_ubuntu_jammy_amd64#108

Can I ask you to take a look? @fujitatomoya

=======================================================
FAIL: test_cli.TestROS2TopicCLI.test_topic_echo_field_not_a_member[rmw_fastrtps_dynamic_cpp]
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\
-------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/ws/install_isolated/launch_testing/lib/python3.10/site-packages/launch_testing/markers.py", line 57, in _wrapper
    return func(self, *args, **kwargs)
  File "/tmp/ws/src/ros2/ros2cli/ros2topic/test/test_cli.py", line 607, in test_topic_echo_field_not_a_member
    assert topic_command.wait_for_output(functools.partial(
AssertionError: assert <BoolWithText(False): "Failed to delete participant.\nInvalid field 'not_member': 'Arrays' object has no attribute 'not_member'\n">
 +  where <BoolWithText(False): "Failed to delete participant.\nInvalid field 'not_member': 'Arrays' object has no attribute 'not_member'\n"> = <bound method ProcessProxy.wait_for_output of <la\
unch_testing.tools.process.ProcessProxy object at 0x7f1fa463b8e0>>(functools.partial(<function expect_output at 0x7f1fd5bb12d0>, expected_lines=["Invalid field 'not_member': 'Arrays' object has\
 no attribute 'not_member'"], strict=True), timeout=10)
 +    where <bound method ProcessProxy.wait_for_output of <launch_testing.tools.process.ProcessProxy object at 0x7f1fa463b8e0>> = <launch_testing.tools.process.ProcessProxy object at 0x7f1fa463\
b8e0>.wait_for_output
 +    and   functools.partial(<function expect_output at 0x7f1fd5bb12d0>, expected_lines=["Invalid field 'not_member': 'Arrays' object has no attribute 'not_member'"], strict=True) = <class 'fu\
nctools.partial'>(<function expect_output at 0x7f1fd5bb12d0>, expected_lines=["Invalid field 'not_member': 'Arrays' object has no attribute 'not_member'"], strict=True)
 +      where <class 'functools.partial'> = functools.partial
 +      and   <function expect_output at 0x7f1fd5bb12d0> = <module 'launch_testing.tools' from '/tmp/ws/install_isolated/launch_testing/lib/python3.10/site-packages/launch_testing/tools/__init_\
_.py'>.expect_output
 +        where <module 'launch_testing.tools' from '/tmp/ws/install_isolated/launch_testing/lib/python3.10/site-packages/launch_testing/tools/__init__.py'> = launch_testing.tools

The error is happening here: https://github.com/ros2/ros2cli/blob/f4e5952f430e502060594d68f3a050b785fd4249/ros2topic/test/test_cli.py#L609

Besides expecting the additional '\n', it seems that the output is now capturing the remaining part of the msg. Failed to delete participant.

@fujitatomoya
Copy link
Collaborator Author

@Blast545 sorry, i will be looking into this. probably CI coverage was not enough.

fujitatomoya added a commit to fujitatomoya/rmw_fastrtps that referenced this pull request Jun 17, 2022
This reverts commit 7202ceb.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

This must be tested on CI with all dependent packages. (not only with rmw_fastrtps_*)

fujitatomoya added a commit that referenced this pull request Jun 17, 2022
This reverts commit 7202ceb.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants