Take all available samples on service/client on_data_available. #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
Just a reference: eProsima/Fast-DDS#2760 |
|
CI:
|
|
CI windows:
|
|
Will this be backported to galactic? |
It certainly can be; it doesn't change API or ABI. Once we have some confirmation that this passes CI and we merge it into Rollng, we can consider backports to Humble and Galactic. |
|
Thanks. Is it also possible to know which service issues get fixed by this update? Just so that we can plan to report/reproduce the remaining? I went through the linked issue but it's a lot of detail that I am not familiar with. The two issues that we face currently :
All services and clients are on the same machine and we are using discovery server. |
|
@clalancette @fujitatomoya I don't think the warnings on the Windows CI are related to this PR. Do you think it can be merged? |
I agree that the warnings are not related to this PR. In that case, we can go ahead and merge this. |
|
@Mergifyio backport humble galactic foxy |
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit e9abdc4)
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit e9abdc4)
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit e9abdc4) # Conflicts: # rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_client_info.hpp # rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_service_info.hpp
✅ Backports have been created
|
jsan-rt
pushed a commit
to eProsima/rmw_fastrtps
that referenced
this pull request
Jul 12, 2022
…#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
jsan-rt
added a commit
to eProsima/rmw_fastrtps
that referenced
this pull request
Jul 13, 2022
* Take all available samples on service/client on_data_available. (ros2#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Initial commit Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Working subscriptions and services Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Add event support Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Initial new event callback Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Use guard_condition with event listeners Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Remove unused functions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Fixing tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Fixing uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Simplify SubListener's get_unread_messages() Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Simplified get_unread_requests() and get_unread_responses() Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Moved Waitset creation/destruction outside loop as suggested Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Renamed variable. Removed unneded checks. Replaced get_unread_count with get_first_untaken_info Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Modified oneliners. Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Cleaned more unneeded checks Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Added RCPPUTILS_TSA_GUARDED_BY macros to previously atomic booleans Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Fixed wrong mutex guard. Renamed and removed break; from TERMINATE_THREAD Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Fix waiting events Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Fixing crash Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Removed unneeded include. Restored some cleanup code. Added some comments. Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Set nullptr after delete Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Detach listener Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev>
aditya2592
pushed a commit
to SBPL-Cruz/rmw_fastrtps
that referenced
this pull request
Nov 1, 2022
…#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
mauropasse
pushed a commit
to mauropasse/rmw_fastrtps
that referenced
this pull request
Jan 19, 2023
…#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
alsora
added a commit
to irobot-ros/rmw_fastrtps
that referenced
this pull request
Jan 19, 2023
Take all available samples on service/client on_data_available. (ros2#616)
quarkytale
pushed a commit
that referenced
this pull request
May 17, 2023
…port #616) (#623) * Take all available samples on service/client on_data_available. (#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit e9abdc4) # Conflicts: # rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_client_info.hpp # rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_service_info.hpp * resolve merge conflicts. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix several issues related with services.