-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take all available samples on service/client on_data_available. #616
Take all available samples on service/client on_data_available. #616
Conversation
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Just a reference: eProsima/Fast-DDS#2760 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Will this be backported to galactic? |
It certainly can be; it doesn't change API or ABI. Once we have some confirmation that this passes CI and we merge it into Rollng, we can consider backports to Humble and Galactic. |
Thanks. Is it also possible to know which service issues get fixed by this update? Just so that we can plan to report/reproduce the remaining? I went through the linked issue but it's a lot of detail that I am not familiar with. The two issues that we face currently :
All services and clients are on the same machine and we are using discovery server. |
@clalancette @fujitatomoya I don't think the warnings on the Windows CI are related to this PR. Do you think it can be merged? |
I agree that the warnings are not related to this PR. In that case, we can go ahead and merge this. |
@Mergifyio backport humble galactic foxy |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit e9abdc4)
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit e9abdc4)
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit e9abdc4) # Conflicts: # rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_client_info.hpp # rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_service_info.hpp
✅ Backports have been created
|
…#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
* Take all available samples on service/client on_data_available. (ros2#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Initial commit Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Working subscriptions and services Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Add event support Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Initial new event callback Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Use guard_condition with event listeners Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Remove unused functions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Fixing tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Fixing uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Simplify SubListener's get_unread_messages() Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Simplified get_unread_requests() and get_unread_responses() Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Moved Waitset creation/destruction outside loop as suggested Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Renamed variable. Removed unneded checks. Replaced get_unread_count with get_first_untaken_info Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Modified oneliners. Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Cleaned more unneeded checks Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Added RCPPUTILS_TSA_GUARDED_BY macros to previously atomic booleans Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Fixed wrong mutex guard. Renamed and removed break; from TERMINATE_THREAD Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Fix waiting events Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Fixing crash Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Removed unneeded include. Restored some cleanup code. Added some comments. Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Set nullptr after delete Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Detach listener Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev>
…#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
…#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Take all available samples on service/client on_data_available. (ros2#616)
…port #616) (#623) * Take all available samples on service/client on_data_available. (#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit e9abdc4) # Conflicts: # rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_client_info.hpp # rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_service_info.hpp * resolve merge conflicts. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This should fix several issues related with services.