Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests take bad arguments #125

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Add tests take bad arguments #125

merged 2 commits into from
Sep 24, 2020

Conversation

Lobotuerk
Copy link
Contributor

No description provided.

Blast545
Blast545 approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, LGTM

test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
hidmic
hidmic reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as in #126 apply.

@Lobotuerk Lobotuerk requested a review from hidmic September 18, 2020 19:20
hidmic
hidmic approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a few nits.

test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_subscription.cpp Show resolved Hide resolved
@Lobotuerk Lobotuerk requested a review from hidmic September 21, 2020 20:17
@Lobotuerk
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

2 similar comments
@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@hidmic
Copy link
Contributor

hidmic commented Sep 24, 2020

@Lobotuerk one more conflict to resolve!

@Lobotuerk
fix merge
f49046b 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk Lobotuerk force-pushed the lobotuerk/take_bad_arguments branch from 213c1c5 to f49046b Compare September 24, 2020 14:31
@Lobotuerk
Copy link
Contributor Author

CI up to test_rmw_implementation after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk Lobotuerk requested a review from ivanpauno September 24, 2020 14:50
@Lobotuerk
fixed warnings
4b14d93 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk
Copy link
Contributor Author

CI up to test_rmw_implementation after 4b14d93 fixes:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk
Copy link
Contributor Author

Merging with green CI

@Lobotuerk Lobotuerk merged commit ffaf45e into master Sep 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the lobotuerk/take_bad_arguments branch September 24, 2020 16:01
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
@Lobotuerk @ahcorde
Add tests take bad arguments (#125)
6bed708 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 21, 2020
@Lobotuerk @ahcorde
Add tests take bad arguments (#125)
9e2f504 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@Blast545 Blast545 Blast545 approved these changes

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lobotuerk @hidmic @Blast545