Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused headers #190

Merged
merged 1 commit into from
May 4, 2021
Merged

Remove unused headers #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rmw_implementation/src/functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

#include "rcutils/allocator.h"
#include "rcutils/format_string.h"
#include "rcutils/get_env.h"
#include "rcutils/types/string_array.h"

#include "rcpputils/get_env.hpp"
Expand Down
1 change: 0 additions & 1 deletion rmw_implementation/test/test_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <memory>

#include "rcutils/env.h"
#include "rcutils/get_env.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't do this here because rcutils_get_env is used below (at least, we can't do this prior to ros2/rcutils#340 being merged). So either this has to remain part of the larger series to move rcutils_get_env into env.h, or we have to switch the test code to use rcpputils::get_env. Either is fine with me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rcutils/env.h includes rcutils/get_env.h, though: https://github.com/ros2/rcutils/blob/ca42bc9f588e11ad40f5879dcb9a364b435d2cba/include/rcutils/env.h#L31

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rcutils/env.h includes rcutils/get_env.h, though: https://github.com/ros2/rcutils/blob/ca42bc9f588e11ad40f5879dcb9a364b435d2cba/include/rcutils/env.h#L31

Ah! I totally missed that. Thanks for the heads up. I'll approve and run CI on this, then.

#include "rcutils/testing/fault_injection.h"

#include "rmw/error_handling.h"
Expand Down