Limit threads per zenoh session #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
force-pushed
the
yadu/limit-threads
branch
from
cb682f8
to
6a7a918
Compare
|
The Zenoh configuration looks good to me. For tracking purposing, I link here a forthcoming PR on Zenoh (eclipse-zenoh/zenoh#566) which will impact the configuration of the Zenoh runtime. Note the the PR will impact only the configuration file, not CMake. |
clalancette
reviewed
Jan 22, 2024
Comment on lines
188
to
190
| // Number of threads dedicated to transmission | ||
| // By default, the number of threads is calculated as follows: 1 + ((#cores - 1) / 4) | ||
| threads: 1, |
There was a problem hiding this comment.
In the CMakeLists.txt, we have a nice comment explaining why we want to limit the threads. Can we have a similar comment here? It might also be a good idea to link to the PR that Luca mentioned.
Signed-off-by: Yadunund <yadunund@openrobotics.org>
clalancette
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #94 by passing
"--no-default-features;--features=zenoh/transport_tcp"to the cargo command invoked when buildingzenoh-c. The default session config is also updated to limit the threads to 1.Special thanks to @cottsay for advising on how to deal with the
;s in cmakecc: @Mallets