Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print service pairs as well #124

Merged
merged 2 commits into from
Jun 19, 2018
Merged

print service pairs as well #124

merged 2 commits into from
Jun 19, 2018

Conversation

dirk-thomas
Copy link
Member

Fixes #115. Connect to #115.

@dirk-thomas dirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) labels Jun 18, 2018
@dirk-thomas dirk-thomas self-assigned this Jun 18, 2018
@dirk-thomas
Copy link
Member Author

The additional output looks like this:

Supported ROS 2 <=> ROS 1 service type conversion pairs:
  - 'example_interfaces/AddTwoInts' (ROS 2) <=> 'roscpp_tutorials/TwoInts' (ROS 1)
  - 'sensor_msgs/SetCameraInfo' (ROS 2) <=> 'sensor_msgs/SetCameraInfo' (ROS 1)
  - 'std_srvs/Empty' (ROS 2) <=> 'std_srvs/Empty' (ROS 1)
  - 'std_srvs/SetBool' (ROS 2) <=> 'std_srvs/SetBool' (ROS 1)
  - 'std_srvs/Trigger' (ROS 2) <=> 'std_srvs/Trigger' (ROS 1)

dhood
dhood approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@dhood dhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be good to update the template header to list the new variable used but LGTM

@dirk-thomas
Copy link
Member Author

be good to update the template header to list the new variable used

Good point - added in 9bda2b2.

@dirk-thomas dirk-thomas merged commit 427eab6 into master Jun 19, 2018
@dirk-thomas dirk-thomas deleted the print_service_pairs branch June 19, 2018 01:38
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhood dhood dhood approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @dhood