Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to avoid deprecated API's #189

Merged
merged 1 commit into from
May 8, 2019
Merged

changes to avoid deprecated API's #189

merged 1 commit into from
May 8, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 7, 2019

Connects to ros2/rclcpp#713

@wjwwood
changes to avoid deprecated API's
3015b90 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood self-assigned this May 7, 2019
@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label May 7, 2019
ivanpauno
ivanpauno reviewed May 7, 2019
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe, it would be good to consider a follow-up PR modifying create_bridge_from_2_to_1, create_bridge_from_2_to_1 and create_bidirectional_bridge to take rclcpp::QoS as an argument.

include/ros1_bridge/factory.hpp Show resolved Hide resolved
include/ros1_bridge/factory.hpp Show resolved Hide resolved
@wjwwood wjwwood merged commit 9184ce8 into master May 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the require_history_depth branch May 8, 2019 21:25
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label May 8, 2019
@dirk-thomas dirk-thomas mentioned this pull request May 9, 2019
Merged
dhananjaysathe pushed a commit to rapyuta-robotics/ros1_bridge that referenced this pull request Aug 22, 2019
@wjwwood @dhananjaysathe
changes to avoid deprecated API's (ros2#189)
6fb379e 
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjwwood @dirk-thomas @ivanpauno