Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate files for interfaces in rmw_dds_common #252

Closed
wants to merge 1 commit into from

Conversation

ivanpauno
Copy link
Member

Fixes ros2/rmw_dds_common#8.

There's no reason to generate files for the interfaces in rmw_dds_common, so I propose to skip them.

Another way to skip the package, is to avoid registering it as a rosidl_interfaces resource.
I can add an argument to rosidl_generate_interfaces to do that.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno self-assigned this Apr 6, 2020
@ivanpauno ivanpauno added bug Something isn't working in review Waiting for review (Kanban column) labels Apr 6, 2020
@dirk-thomas
Copy link
Member

This package should not need to know about rmw_dds_common so this should not be merged

I don't know enough about how the interface in that package are needed to recommend an approach.

@dirk-thomas dirk-thomas closed this Apr 6, 2020
@ivanpauno
Copy link
Member Author

Another way to skip the package, is to avoid registering it as a rosidl_interfaces resource.
I can add an argument to rosidl_generate_interfaces to do that.

Does this sound reasonable?

@ivanpauno ivanpauno deleted the ivanpauno/fix-rmw-dds-common branch April 6, 2020 15:26
@dirk-thomas
Copy link
Member

I don't understand why they must be installed but can't be registered at the index.

@ivanpauno
Copy link
Member Author

I don't understand why they must be installed but can't be registered at the index.

They must be installed because rmw_fastrtps_cpp and rmw_fastrtps_dynamic_cpp use them.

They don't need to be registered at the index because they are not intended to be an interface used by the end user.

@ivanpauno
Copy link
Member Author

See ros2/rmw_dds_common#11 and ros2/rosidl#454.

@dirk-thomas
Copy link
Member

They don't need to be registered at the index because they are not intended to be an interface used by the end user.

The question remains: what is the problem for them being registered at the index?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breaks building ros1_bridge
2 participants