-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove installation landing page [rolling] #1132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maryaB-osr <marya@openrobotics.org>
Signed-off-by: maryaB-osr <marya@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
inst-landing
branch
from
February 25, 2021 14:36
2564fbb
to
22672a0
Compare
clalancette
reviewed
Feb 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question inline, then this looks pretty good.
Signed-off-by: maryaB-osr <marya@openrobotics.org>
…tion into inst-landing Signed-off-by: maryaB-osr <marya@openrobotics.org>
Signed-off-by: maryaB-osr <marya@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
approved these changes
Feb 25, 2021
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2021
* remove rolling installation landing page Signed-off-by: maryaB-osr <marya@openrobotics.org> * remove rolling installation landing page Signed-off-by: maryaB-osr <marya@openrobotics.org> * Fix the links. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * shorten title, mention distro in first line Signed-off-by: maryaB-osr <marya@openrobotics.org> * shorten title Signed-off-by: maryaB-osr <marya@openrobotics.org> * Fix one more installation link. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit a2e84b3) # Conflicts: # source/Installation.rst # source/Releases/Release-Rolling-Ridley.rst
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2021
* remove rolling installation landing page Signed-off-by: maryaB-osr <marya@openrobotics.org> * remove rolling installation landing page Signed-off-by: maryaB-osr <marya@openrobotics.org> * Fix the links. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * shorten title, mention distro in first line Signed-off-by: maryaB-osr <marya@openrobotics.org> * shorten title Signed-off-by: maryaB-osr <marya@openrobotics.org> * Fix one more installation link. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit a2e84b3) # Conflicts: # source/Installation.rst # source/Installation/Summary.rst # source/Releases/Release-Rolling-Ridley.rst
clalancette
added a commit
to clalancette/ros2_documentation
that referenced
this pull request
Mar 1, 2021
This is necessary now that ros2#1132 and friends landed. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Mar 1, 2021
This is necessary now that #1132 and friends landed. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ferranm99
added a commit
to ferranm99/ferran-ros
that referenced
this pull request
May 20, 2022
This is necessary now that ros2/ros2_documentation#1132 and friends landed. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: maryaB-osr marya@openrobotics.org