Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove installation landing page [rolling] #1132

Merged
merged 7 commits into from
Feb 25, 2021
Merged

Remove installation landing page [rolling] #1132

merged 7 commits into from
Feb 25, 2021

Conversation

maryaB-osr
Copy link
Contributor

Signed-off-by: maryaB-osr marya@openrobotics.org

Signed-off-by: maryaB-osr <marya@openrobotics.org>
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-1132 February 24, 2021 18:49 Inactive
maryaB-osr and others added 2 commits February 25, 2021 09:36
Signed-off-by: maryaB-osr <marya@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-1132 February 25, 2021 14:36 Inactive
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question inline, then this looks pretty good.

source/Installation.rst Outdated Show resolved Hide resolved
Signed-off-by: maryaB-osr <marya@openrobotics.org>
…tion into inst-landing

Signed-off-by: maryaB-osr <marya@openrobotics.org>
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-1132 February 25, 2021 16:20 Inactive
Signed-off-by: maryaB-osr <marya@openrobotics.org>
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-1132 February 25, 2021 16:21 Inactive
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@maryaB-osr maryaB-osr merged commit a2e84b3 into rolling Feb 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the inst-landing branch February 25, 2021 19:35
mergify bot pushed a commit that referenced this pull request Feb 25, 2021
* remove rolling installation landing page

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* remove rolling installation landing page

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* Fix the links.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* shorten title, mention distro in first line

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* shorten title

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* Fix one more installation link.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit a2e84b3)

# Conflicts:
#	source/Installation.rst
#	source/Releases/Release-Rolling-Ridley.rst
mergify bot pushed a commit that referenced this pull request Feb 25, 2021
* remove rolling installation landing page

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* remove rolling installation landing page

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* Fix the links.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* shorten title, mention distro in first line

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* shorten title

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* Fix one more installation link.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit a2e84b3)

# Conflicts:
#	source/Installation.rst
#	source/Installation/Summary.rst
#	source/Releases/Release-Rolling-Ridley.rst
clalancette added a commit to clalancette/ros2_documentation that referenced this pull request Mar 1, 2021
This is necessary now that ros2#1132
and friends landed.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette added a commit that referenced this pull request Mar 1, 2021
This is necessary now that #1132
and friends landed.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ferranm99 added a commit to ferranm99/ferran-ros that referenced this pull request May 20, 2022
This is necessary now that ros2/ros2_documentation#1132
and friends landed.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants