Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release note about change to log file flushing (backport #3193) #3196

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 18, 2022

This is an automatic backport of pull request #3193 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* release note about change to log file flushing

ros2/rcl_logging#95

* mention the volatility of the env var

* Apply suggestions from code review

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>

* emphasize note about experimental status

also link to issue about logging config file plans

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Audrow Nash <audrow@openrobotics.org>
(cherry picked from commit 2002bbd)
@mergify mergify bot requested review from clalancette and audrow as code owners November 18, 2022 23:43
@clalancette clalancette merged commit 8f3c91d into humble Nov 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-3193 branch November 21, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants