Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mergify from action #3882

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

cychitivav
Copy link
Contributor

@cychitivav cychitivav commented Aug 29, 2023

I have made several contributions and have noticed that Mergify generates a new pull request for each backport branch. This leads to the GitHub action being triggered 8 times for every accepted pull request.

image

Due to this issue, I suggest excluding the check from the triggers for branches that begin with mergify/bp/. By doing so, we can prevent 4 unnecessary executions (2 from Iron and 2 from Humble).

It would be beneficial to also implement a feature that disables triggering upon each branch merge.

@cychitivav cychitivav marked this pull request as ready for review August 29, 2023 02:20
cychitivav and others added 2 commits August 31, 2023 07:39
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Sep 15, 2023
@clalancette clalancette merged commit 3057500 into ros2:rolling Sep 15, 2023
mergify bot pushed a commit that referenced this pull request Sep 15, 2023
* GitHub trigger updated for just pull requests

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3057500)
mergify bot pushed a commit that referenced this pull request Sep 15, 2023
* GitHub trigger updated for just pull requests

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3057500)
clalancette pushed a commit that referenced this pull request Sep 15, 2023
* GitHub trigger updated for just pull requests

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3057500)

Co-authored-by: Cristian Chitiva <cychitivav@unal.edu.co>
clalancette pushed a commit that referenced this pull request Sep 15, 2023
* GitHub trigger updated for just pull requests

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3057500)

Co-authored-by: Cristian Chitiva <cychitivav@unal.edu.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants