Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not drop future returned by async_send_goal. #3921

Closed
wants to merge 1 commit into from
Closed

Do not drop future returned by async_send_goal. #3921

wants to merge 1 commit into from

Conversation

fujitatomoya
Copy link
Collaborator

doc fix for ros2/demos#649

@fujitatomoya
Do not drop future returned by async_send_goal.
7df65b7 
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Sep 16, 2023
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines are bit aligned with sample code change.

@fujitatomoya fujitatomoya removed the request for review from clalancette September 17, 2023 22:55
@fujitatomoya
Copy link
Collaborator Author

@clalancette could you take a look at this? this needs to go in with ros2/demos#649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fujitatomoya